[MGNLUI-5994] Deprecate sortable in favor of sortByProperties to simplify Created: 24/Jun/20  Updated: 21/May/21  Resolved: 09/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.7

Type: Improvement Priority: Neutral
Reporter: Šimon Demočko Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: VN-Testing
Remaining Estimate: Not Specified
Time Spent: 1.25h
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-6672 Cannot disable automatic sorting in c... Closed
documentation
to be documented by MGNLUI-6617 DOC: Update sorting properties in Dat... Closed
relation
is related to MGNLUI-3814 Allow configuration of defaultOrder i... Closed
Template:
Acceptance criteria:
[X]* remove usage from viewConfiguration.yaml false is default anyway. Addons approved this in this slack thread
[X]* Consider filing ADR about this decision
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes
Documentation update required:
Yes
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI FW 23
Story Points: 3

 Description   

We currently have to configure sortable: true over datasource definition to have sorting working, even if sortByProperties is configured. This is unintuitive. When you define sortByProperties, one expects it will sort. Multiple devs got confused by this. The [docs|https://documentation.magnolia-cms.com/display/DOCS62/JCR+data+source] also do not mention it.

 



 Comments   
Comment by Christopher Zimmermann [ 25/Jan/21 ]

If it makes sense, it would be nice to also consider (and ideally implement) how the direction of the default sort can be configured. See related ticket: 
https://jira.magnolia-cms.com/browse/MGNLUI-3814

Comment by Šimon Demočko [ 25/Jan/21 ]

That would be out of the scope of this issue. This one is well-defined as just removal of the unnecessary property + method. Would keep direction behaviour in the original scope of MGNLUI-3814

Generated at Mon Feb 12 09:32:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.