[MGNLUI-6089] Title is mandatory in dialogs Created: 27/Jul/20  Updated: 07/Sep/20  Resolved: 19/Aug/20

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 6.2.3

Type: Bug Priority: Neutral
Reporter: Mercedes Iruela Assignee: Martin Haderka
Resolution: Fixed Votes: 0
Labels: 622
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2020-07-27 at 14.06.44-1.png     PNG File Screenshot 2020-07-27 at 14.06.44.png     PNG File Screenshot 2020-07-27 at 14.10.56.png    
Issue Links:
Problem/Incident
is caused by MGNLUI-5814 Using labels at the form level is now... Closed
Relates
relates to MGNLUI-6122 Dialog: Label of the form is ignored ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI FW 9
Story Points: 2

 Description   

Steps to reproduce

1. Create a new dialog
2. Ensure that the dialog has not message key defined.
3. Open the dialog, the label key is mandatory.

Expected results

In 5.7, the key was not mandatory so the dialog title was displayed as empty when no message key was defined.

Actual results

A message key is mandatory

Workaround
N/A

Development notes

  • Use newly introduced fallback to empty string

Related to MGNLUI-5814



 Comments   
Comment by Roman Kovařík [ 18/Aug/20 ]

What about making it mandatory for converted fields (old framework definitions), not the ones created as new framework definitions?

Otherwise you would need to know the i18n key from top of your head if you actually want to have a title.

And you can always set label: "" in your definition if you want to omit the title.

Generated at Mon Feb 12 09:33:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.