[MGNLUI-6118] Type Long in JCR should not have commas Created: 05/Aug/20 Updated: 24/Feb/21 Resolved: 24/Feb/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.2.6 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Richard Gange | Assignee: | Unassigned |
| Resolution: | Declined | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
|
| Comments |
| Comment by Šimon Demočko [ 24/Feb/21 ] |
|
Hi, I think in cases where the long is actually long (10+ digits, which it is designed for anyway) and the value is for human reading, then the commas are added after every three digits to increase readability. Compare: 856498567448 with 856,498,567,448. So just removing commas for Longs would improve for port, but worsen for any other more reasonable context. It's not such a clear-cut decision. Also, port will never outgrow integer range, so it probably shouldn't be Long-typed in the first place |
| Comment by Richard Gange [ 24/Feb/21 ] |
|
Ok, that sounds logical. For me I just use String everywhere and then convert it later. |
| Comment by Šimon Demočko [ 24/Feb/21 ] |
|
Closing as declined: The ticket is malformed, the implicit expectation is unfounded. Reopen if necessary with more reasoning. |
| Comment by Šimon Demočko [ 24/Feb/21 ] |
|
Sure, like mentioned, feel free to repurpose the ticket with a more explicit, rephrased expectation: e.g. Port should use Integer as data type, or something in that direction. Or a new ticket. It was closed because a property of Long showing comma after 3 digits is not a bug. Without expected results founded on some documentation or UX decision, this isn't something the UI team can/should work on. In case we still think Long shouldn't have commas, that has to go to UX first, because the comma is there for a reason. |