[MGNLUI-612] ActionbarPresenter's interface and implementation is too strict. Created: 29/Jan/13 Updated: 28/Feb/13 Resolved: 28/Feb/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.0 |
| Fix Version/s: | 5.0 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Espen Jervidalo |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Description |
|
ActionbarPresenter's createAndExecuteAction assumes there must be some JCR Item for which the action is fired. In case of ImageEditor (BL-97) for instance, this is not true - the actions should be just fired. It would probably be correct to extract the common part of the ActionbarPresenter in a separate class. |
| Comments |
| Comment by Tobias Mattsson [ 14/Feb/13 ] |
|
With the changes planned for |
| Comment by Espen Jervidalo [ 28/Feb/13 ] |
|
fixed in linked ticket |