[MGNLUI-613] Enable BaseDialog to have a settable header and footer component. Created: 29/Jan/13  Updated: 18/Mar/13  Resolved: 18/Mar/13

Status: Closed
Project: Magnolia UI
Component/s: dialogs
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: BL-97
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-614 Implement stubs on FormViewimpl for s... Sub-task Closed Christopher Zimmermann  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

setFooter() and setHeader() methods will be added to BaseDialog. It will allow setting components for the footer or header (as one can now do for the content). This is a requirement to support features of the Asset Editor and Image Editor where the header/footer can contain arbitrary contents.

This will include to various related files like EditorLikeComponentConnector, EditorLikeComponentState, EditorLikeViewInterface etc.



 Comments   
Comment by Christopher Zimmermann [ 04/Feb/13 ]

Because so much existing and new code was shared between BaseDialog and Form, they both now extend a new abstract class: EditorLike.
EditorLike has a setFooterToolbar and setHeaderToolbar method which accept a component. Like the content component, the toolbars are added to the EditorLikeComponentState object.
EditorLikeConnector gets these components and injects them in the view when there is a hierarchyChange event.

To make EditorLike as generic as possible, a new EditorLikeActionListener interface replaces FormActionListener and DialogActionListener.

setHeaderComponent is not yet implemented on the widgets as Mikael has made changes to the header - waiting for his commits.

Comment by Christopher Zimmermann [ 07/Feb/13 ]

Implemented setHeaderToolbar for form and dialogs.

Comment by Daniel Lipp [ 14/Feb/13 ]
  • Javadoc of all client types (e.g. EditorLikeView) just contains the type name
  • EditorLikeComponentConnector has TODO without author
  • EditorLike introduces commented out code: asVaadinComponent (#165-170)
Comment by Jozef Chocholacek [ 07/Mar/13 ]

Wrong year used in header - even in newly added files such as EditorLike.java, EditorLikeHeaderWidget.java etc.

Comment by Christopher Zimmermann [ 18/Mar/13 ]

Added 2013 to class headers.

Comment by Christopher Zimmermann [ 18/Mar/13 ]

Added 2013 to class headers.

Generated at Mon Feb 12 08:38:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.