[MGNLUI-6170] Dialog still visible after firing LocationChangedEvent Created: 31/Aug/20  Updated: 18/Feb/22  Resolved: 13/Dec/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.13
Fix Version/s: 6.2.15

Type: Bug Priority: Neutral
Reporter: Šimon Demočko Assignee: Roman Kovařík
Resolution: Fixed Votes: 0
Labels: 62-UI-3, maintenance, ui-ux-impr
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
clones MGNLCDEP-110 Dialog is not closed after firing Loc... Closed
causality
is causing MGNLUI-7039 URL after opening app should always c... Closed
relation
supersession
supersedes MGNLUI-4199 Allow only single specificed app's ch... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI Maintenance 3
Story Points: 2

 Description   

Cloned from MGNLCDEP-110 b/c this is relevant in any context where location change happens using the LocationController.

When a dialog contains a field that redirects to another location by firing a LocationChangedEvent when clicking on it (no action buttons involved), it is not closed after redirecting to the new location and, therefore, it is not visible and not user friendly as they have to close the dialog.

This can be reproduced in the dependencies tab from content dependencies module.

Steps to reproduce in demo:

  1. Configure dependencies tab as explained in docs
  2. Go to pages app, travel/about and open the editor
  3. Click on "edit page properties" and go to dependencies tab
  4. Click on dependency /travel
  5. Dialog is not closed and redirection occurs behind

When using Magnolia 5 UI with -m5 parameter, this doesn't happen, which seems closely related to the usage of info.magnolia.ui.framework.app.DefaultAppView in UI 5 instead of info.magnolia.admincentral.AdmincentralAppView used in UI 6, which in turn, means that Magnolia class method (info.magnolia.ui.vaadin.tabsheet.MagnoliaTabSheet.setActiveTab(MagnoliaTab)) is called in 5 UI whereas Vaadin class method ((com.vaadin.ui.TabSheet.setSelected(Component)) is called in 6 UI. There should be a way to close the dialog in the new UI.



 Comments   
Comment by Roman Kovařík [ 13/Dec/21 ]

For release notes:
when user leaves an app (e.g. via a link to another app), opened dialogs are hidden until users returns to the app which has opened those.

Generated at Mon Feb 12 09:33:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.