[MGNLUI-6175] Lowercase labels in German Created: 01/Sep/20  Updated: 13/Jan/21  Resolved: 21/Oct/20

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.2
Fix Version/s: 6.2.4

Type: Improvement Priority: Neutral
Reporter: Monica Damborenea Assignee: Chuong Doan Huy
Resolution: Fixed Votes: 0
Labels: maintenance
Remaining Estimate: Not Specified
Time Spent: 0.75d
Original Estimate: Not Specified

Attachments: PNG File Image 2020-09-01 at 9.09.29 AM.png    
Issue Links:
Relates
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Epic Link: M6 UI & UX Improvements
Sprint: Maintenance 29, Maintenance 30
Story Points: 2

 Description   

When migrating to 6.2, we introduced normalizing all labels to lowercase and let only the first letter be capitalized, in order to have a more consistent look and feel. Which makes sense in the rest of the languages but not in German (nouns in German are all capitalized).

Steps to reproduce

The example the customer sent is in the old pages app, they noticed it also in collapsables in the stories app.

  1.  Remove the hidden app in configuration/modules/ui-admincentral/config/appLauncherLayout/hiddenApps
  1. Change to German language
  2. Go to the old pages app, click on a variant and see the action bar in the right with action "Alle Varianten publizieren"
  3. Click on that action and note that in the button, the word Varianten is now in lowercase.

Check it out in this screenshot

Expected results

We should see Varianten in capital letter as in the action bar.

 

Development notes

Check the CSS that is transforming to lowercase the labels:

https://demoauthor.magnolia-cms.com/VAADIN/themes/resurface-admincentral/styles.css?v=8.9.4

.v-button span.v-button-caption, .magnoliabutton span.v-button-caption 
{ # display: inline-block; # text-transform: lowercase; }
.v-button span.v-button-caption::first-letter, .magnoliabutton span.v-button-caption::first-letter 
{ # text-transform: capitalize; }

 
Labels in i18n files should follow the guidelines; we should not rely on the CSS transformation.


Generated at Mon Feb 12 09:33:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.