[MGNLUI-6398] Remove grid scroll extension Created: 10/Nov/20  Updated: 10/Jun/21  Resolved: 23/Dec/20

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.6
Fix Version/s: 6.2.6

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Roman Kovařík
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 3.3h
Original Estimate: Not Specified

Issue Links:
Issue split
split from MGNLPER-135 Long running searches cause performan... Closed
Relates
relates to MGNLVA-11 CLONE - Columns "drift" sizes when or... Closed
causality
caused by MGNLUI-6242 Scroll to selected item does not work... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: Scroll to selected item
Sprint: UI FW 18 (christmas)
Story Points: 5

 Description   

Timeboxed to 5

Usage of this extension seems obsolete after MGNLUI-6242 as the grid now scroll to the selected item (tree) or lists selected items at top (list).

We still use one method though (#adjustColumnWidth).

We even had to fix issue with this extension, see https://git.magnolia-cms.com/projects/PLATFORM/repos/vaadin-compatibility-addons/browse/vaadin-compatibility-grid-scroll-extension

Steps to do

  • Removal from framework grids 
  • Removal from FindBar
  • Removal from widgetset
  • (possibly new ticket) remove custom fix in vaadin addons

Acceptance criteria

  • ensure there are no infinite polls when you open up an app with a grid when any of your workspaces have a lot of data in it.
    • For that, you can use [^pageCreationScript] this script in Groovy Module to fill page workspace with 50000 nodes. Then open up any app, even an empty one, and observe in DevTools that there's infinite polling taking place. It will look very much like in this video [^2020-11-09 10-15-33.mp4] 
  • Ensure no critical functionality was lost with the removal of the extension
  • Also, consider
    • drop maintenance of our custom fix
    • drop dependency to 3rd party widgets 

Generated at Mon Feb 12 09:36:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.