[MGNLUI-6482] Dialog crashes if linkfield has unsupported value Created: 22/Dec/20  Updated: 17/Dec/21  Resolved: 13/Dec/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.11
Fix Version/s: 6.2.15

Type: Bug Priority: Neutral
Reporter: Mercedes Iruela Assignee: Quach Hao Thien
Resolution: Fixed Votes: 1
Labels: VN-Maintenance
Remaining Estimate: Not Specified
Time Spent: 1d 7h
Original Estimate: Not Specified

Issue Links:
Relates
duplicate
is duplicated by MGNLUI-6914 LinkField: Dialog does not open, if s... Closed
is duplicated by MGNLUI-6968 NullPointerException when opening app... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: Improve Content Linking
Sprint: UI Maintenance 3
Story Points: 3

 Description   

Steps to reproduce

  1.  In contacts-v8 app create a new contact and add and fill out linkfield field.
  2.  go to the jcr and change the link field value to anything which isn't a uuid and a path

Expected results

The field should show empty as it used to be in 5.7

Actual results

Detail subapp crashed.

Workaround

No storing valued different to uuid or path

Development notes

In 5.7 same steps displayed an empty value



 Comments   
Comment by Adam Siska [ 12/Aug/21 ]

I don't think that the 2nd step is acceptable as a reproduction step.. IMHO

javax.jcr.RepositoryException: invalid identifier

is completely relevant here and should be displayed as an error, WDYT?

Comment by Adam Siska [ 12/Aug/21 ]

Or I would rename the ticket to "Dialog crashes if linkfield has corrupted value". But make it an improvement to make linkField more robust (not sure we do things like this) That means that you can achieve to throw exceptions in UI by corrupting nodes with JCR Browser..

Comment by Roman Kovařík [ 12/Aug/21 ]

Aha ok, I've confused this with recent changes in damLinkField.

Indeed this requirement is rather dangerous as it'd silently ignore corrupted data.

Not sure what "UI crashes means" though, I don't think the whole admincentral crashes.

Comment by Roman Kovařík [ 03/Dec/21 ]

Estimated: fix the converter.

Comment by wolf bubenik [ 03/Dec/21 ]

We (aperto) encountered the same behaviour with multi select of values from an other app (twinColSelectField). When one of the linked selections has been removed, the complete content is not editable any more. See linked ticket for our provisorily patch.

 

Comment by Roman Kovařík [ 09/Dec/21 ]

Hi wolf.bubenik

 

This ticket is about an unsupported  (nor path or UUID) value, not about a deleted value. 

I wasn't able to reproduce the deleted node issue with:


form:
  properties:
    test:
      $type: twinColSelectField
      datasource:
        $type: jcrDatasource
        workspace: website

but feel free to reopen MGNLUI-6968 and add steps to reproduce on https://demo.magnolia-cms.com/.magnolia/admincentral.

 

Regards

Roman

Generated at Mon Feb 12 09:36:55 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.