[MGNLUI-6515] Chooser injects observation of the underlying app Created: 19/Jan/21 Updated: 23/Feb/23 Resolved: 23/Feb/23 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.2.6 |
| Fix Version/s: | 6.3.0, 6.2.29 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Fernando Cherchi |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 34m | Time Spent: | 34m |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
||||||||||||||||||||||||||||||
| Sub-Tasks: |
|
||||||||||||||||||||||||||||||
| Template: | |||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
[X]*
I can still upload new image in asset dialog and the view is refreshed
|
||||||||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
||||||||||||||||||||||||||||||
| Epic Link: | Datasource observation | ||||||||||||||||||||||||||||||
| Sprint: | Nucleus 30 | ||||||||||||||||||||||||||||||
| Story Points: | 2 | ||||||||||||||||||||||||||||||
| Team: | |||||||||||||||||||||||||||||||
| Work Started: | |||||||||||||||||||||||||||||||
| Description |
Steps to reproduce
Expected resultsAs author, I don't have to see the changes by other authors when chooser is opened. It's OK if I get new data as soon I open the chooser again. Moreover observation actions are unregistered after closing the chooser or even better choosers doesn't need an auto refresh mechanism to improve performance. Actual resultsThe change is immediately visible in the chooser. Moreover observation actions are not unregistered after closing the chooser but are accumulating. This is not so harmful but also completely useless. WorkaroundUsually not needed but closing the app cleans up. Development notesWe probably need to bind instance of the observation (preferable no-op = no auto refreshes of the chooser), same way as we bind a dedicated ValueContext for the chooser. |
| Comments |
| Comment by Roman Kovařík [ 09/Feb/23 ] |
|
Discovery: implement/bind no-op observation, same way as we bind filters context to choosers: https://git.magnolia-cms.com/plugins/servlet/search?q=bindContext(FilterContext.class) |