[MGNLUI-6545] Folders should be displayed in thumbnail view as an icon Created: 02/Feb/21  Updated: 04/Jan/22  Resolved: 03/Jan/22

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.5
Fix Version/s: 6.2.16

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: Jaromir Sarf
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Screenshot 2021-02-02 at 11.15.56.png    
Issue Links:
Problem/Incident
duplicate
is duplicated by MGNLUI-6933 Broken images in asset thumbnail view Open
is duplicated by MGNLUI-5348 Broken folder preview in thumbnail view Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: Migrate Assets
Sprint: UI Maintenance 4
Story Points: 2

 Description   

Steps to reproduce

  1. Open assets app
  2. Open thumbnail view 

Expected results

Only assets are shown

Actual results

Folders are also shown, which don't show an icon so lots of empty thumbnails appear

Workaround

Development notes

This is happening because when info.magnolia.ui.contentapp.browser.ThumbnailView instantiates info.magnolia.ui.vaadin.layout.LazyThumbnailLayout, it is making use of the configured info.magnolia.ui.contentapp.JcrDataProvider, which retrieves the configuration from the datasource definition, allowedNodeTypes property (mgnl:folder and mgnl:asset)
On the contrary, in the old assets app, info.magnolia.ui.workbench.thumbnail.JcrThumbnailContainer was used, which includes a specific constraint not to retrieve items of type mgnl:folder

Final solution

Folder icons is use as preview for folders.



 Comments   
Comment by Roman Kovařík [ 03/Dec/21 ]

Estimated: show folder icon as folder preview.

Comment by Jaromir Sarf [ 29/Dec/21 ]

For RN:
Folders in thumbnail view in Assets app have svg icon as thumbnail image.

Comment by Roman Kovařík [ 30/Dec/21 ]

Reopened: the folder icon shows also in actionbar:

  • Doesn't look good on black background.
  • Just takes space without additional value
Generated at Mon Feb 12 09:37:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.