[MGNLUI-6569] Big performance impact showing tags column in browser subapp Created: 17/Feb/21 Updated: 17/Jun/21 Resolved: 23/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.2.6 |
| Fix Version/s: | 6.2.7 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Jorge Franco | Assignee: | Roman Kovařík |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | VN-Testing, performance | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | 0.25d | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: | |||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
[X]*
editable token field in form works
|
||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
||||||||||||
| Release notes required: |
Yes
|
||||||||||||
| Date of First Response: | |||||||||||||
| Epic Link: | Grid performance | ||||||||||||
| Sprint: | UI FW 24 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Description |
|
In pages there is this decoration in our demo https://git.magnolia-cms.com/projects/ENTERPRISE/repos/text-classification/browse/pages-content-tags-integration/src/main/resources/pages-content-tags-integration/decorations/pages-app/apps/pages-app.subApps.browser.yaml#55
Draw that column takes a lot of time. It can happens with other column definitions and in other applications, for example similar decoration in Assets app. More information https://jira.magnolia-cms.com/browse/DEV-1718.
Introduce empty data source for read-only, this will allow not to have to deal with styling changes. This uses a component. A lighter approach is to use pure HTML with applied styles, but the above should suffice since that is the most contributing factor of performance drop. We'll create a new one if this doesn't fix it. |
| Comments |
| Comment by Roman Kovařík [ 23/Feb/21 ] |
|
What I always wonder is why the comboBox is doing fetch before any user interaction with the field. It's probably because it extends an abstract select where you usually need to display all options. In case of the combo is doesn't make sense especially if it's read only. There we can use a similar trick as in the link field...use an empty datasource. |
| Comment by Roman Kovařík [ 24/Mar/21 ] |
|
For release notes: There were some performance issues with the tags column in the browser subapp as every row would fetch all nodes from the `tags` workspace. |