[MGNLUI-6622] Non editable link field should not display remove button Created: 15/Mar/21  Updated: 23/Mar/21  Resolved: 22/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.7
Fix Version/s: 6.2.7

Type: Bug Priority: Neutral
Reporter: Martin Haderka Assignee: Martin Haderka
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: 2h 41m
Original Estimate: Not Specified

Attachments: File Screen Recording 2021-03-15 at 11.13.36.mov     PNG File Screenshot 2021-03-15 at 09.32.54.png    
Issue Links:
causality
caused by MGNLUI-6530 Improve LinkField with a select menu ... Closed
Template:
Acceptance criteria:
[X]* LinkField item has "Select new" button after a value is selected (editable = true)
[X]* LinkField item has NO "x" and "Select new" button after a value is selected (editable = false)
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: Improve Content Linking
Sprint: UI FW 24
Story Points: 2

 Description   

Steps to reproduce

1. Open https://demo.magnolia-cms.com/.magnolia/admincentral#app:pages-app:detail;/travel:edit with MGNLUI-6530 applied
2. Add a new component
3. Choose Tour Carousel component
4. Click on "Add" in Select Tours
5. Choose new item by clicking on "Select new" button
6. Select any item

Expected results

7. "x" button shouldn't be available

Actual results

7. Clicking on "x" button will cause blank item

(see attached screen recording)

Workaround

Remove blank item with trash icon

Note

Tour Carousel has editable = false, therefore it shouldn't be possible to change a value after selecting one



 Comments   
Comment by Roman Kovařík [ 15/Mar/21 ]

As a side note, info.magnolia.ui.field.AbstractLinkField#setButtonCaptionAndDescription seems to be redundant as the chooser button label is not changed dynamically anymore.

Generated at Mon Feb 12 09:38:20 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.