[MGNLUI-667] AppController: currentAppInstanceController set too late, causes null pointer Created: 18/Feb/13  Updated: 20/Feb/13  Resolved: 20/Feb/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Bug Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-668 AppController: appHistory updated to ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Comments   
Comment by Tobias Mattsson [ 20/Feb/13 ]

I think you're breaking the app history with this change, because now this if statement is always true:

        if (currentAppInstanceController != nextAppContext) {
            appHistory.addFirst(nextAppContext);
        }

Also, it might make sense to make doStartIfNotAlreadyRunning() return void instead.

Comment by Tobias Mattsson [ 20/Feb/13 ]

Oh, I see MGNLUI-668 was already tracking this.

Generated at Mon Feb 12 08:39:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.