[MGNLUI-6694] Old pages app: Labels from multivalue inner fields are not shown Created: 12/May/21  Updated: 22/Mar/23  Resolved: 21/Mar/23

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.8
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Jonathan Ayala Assignee: Dominik Maslanka
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File test-panel.yaml    
Issue Links:
Cloners
clones MGNLUI-6467 Old pages app: Labels from composite/... Closed
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Date of First Response:
Epic Link: Old framework
Team: Nucleus

 Description   

Steps to reproduce

  1.  Use the attached dialog for a component
  2.  Open pages app (note it is not pages-app) and edit/create a page
  3. Add the component from step 1

test-panel.yaml

Expected results

Dialog is correctly shown with labels for all its fields

Actual results

No labels are shown for the inner fields 

Workaround

Migrate dialog to 6UI or using pages-app

Development notes

This happens because a css class,force-hide-field-captions, is assigned to v-caption-on-top elements
In new pages-app labels are correctly shown:

Probably some rule change happened in 6.2 affecting the old, since rulesets are shared partially. 

May be related: https://git.magnolia-cms.com/projects/PLATFORM/repos/ui.pub/commits/2ec30fbc56ff68db95d9d55a4be7ea0f9e7a1ec6#magnolia-ui-framework/src/main/java/info/magnolia/ui/framework/layout/field/FieldLayoutComponent.java

 



 Comments   
Comment by Adam Siska [ 12/May/21 ]

related discussion: https://magnolia-cms.slack.com/archives/CKSC4TJQK/p1620816916026500

Comment by Jaromir Sarf [ 13/Mar/23 ]

Discovery:
Restyles labels in old framework like it is in the new one. The main thing is removing display: none from style below and add there line-height: 22px;.

.force-hide-field-captions .v-formlayout-contentcell .v-caption-on-top > .v-caption, .force-hide-field-captions .v-formlayout-contentcell .v-caption-on-top > .v-caption-v-form-field {
display: none;
} 
Comment by Dominik Maslanka [ 21/Mar/23 ]

Hello, This ticket is now marked as closed due to one of the following reasons:

  • A long period of inactivity
  • Uses an old or Beta version of an application, module, or framework that we no longer support
  • The issue is no longer reproducible or has been fixed in later versions

If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you. Thank you,

The Magnolia Team

Generated at Mon Feb 12 09:39:04 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.