[MGNLUI-6696] showOptions setting with damLinkField leads to UI exception Created: 17/May/21  Updated: 16/Jul/21  Resolved: 12/Jul/21

Status: Closed
Project: Magnolia UI
Component/s: dialogs, framework
Affects Version/s: 6.2.8, 6.2.10
Fix Version/s: 6.2.11

Type: Bug Priority: Neutral
Reporter: Viet Nguyen Assignee: Adam Siska
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Zip Archive image-test.zip    
Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[X]* Steps to reproduce, expected, and actual results filled
[X]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: UI framework implementation
Sprint: UI FW 32
Story Points: 5

 Description   

Steps to reproduce

  1.  Add showOptions: true to a damLinkField
  2.  Select an image and save the dialog(do not select another or remove the selected image)
  3. Open the dialog again, click save.

If testing without demo, make sure you have at least two locales available

Expected results

The dialog is saved.

Actual results

An exception is thrown.

Workaround

showOptions: false

Development notes



 Comments   
Comment by Daniel Schneeberger [ 21/Jun/21 ]

We are also experiencing this issue.

Regarding the the attached stacktrace above. I see that after not beeing able to save the component as described above, the log gets spammed with stack traces (looking the same as the last one in the description above). The last one I get is this:

Caused by: java.lang.StackOverflowErrorCaused by: java.lang.StackOverflowError at com.vaadin.ui.AbstractListing.internalGetDataProvider(AbstractListing.java:177) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.ComboBox.getDataProvider(ComboBox.java:965) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.AbstractSingleSelect.isSelected(AbstractSingleSelect.java:222) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.AbstractSingleSelect.setSelectedItem(AbstractSingleSelect.java:338) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.AbstractSingleSelect.setSelectedItem(AbstractSingleSelect.java:119) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.AbstractSingleSelect.setValue(AbstractSingleSelect.java:153) ~[vaadin-server-8.12.4.jar:8.12.4] at info.magnolia.ui.field.AbstractLinkField.doSetValue(AbstractLinkField.java:115) ~[magnolia-ui-framework-6.2.8.jar:?] at com.vaadin.ui.AbstractField.setValue(AbstractField.java:140) ~[vaadin-server-8.12.4.jar:8.12.4] at com.vaadin.ui.AbstractField.setValue(AbstractField.java:53) ~[vaadin-server-8.12.4.jar:8.12.4] at info.magnolia.ui.editor.FormPresenter.lambda$null$10(FormPresenter.java:197) ~[magnolia-ui-framework-6.2.8.jar:?] at java.util.Optional.ifPresent(Optional.java:159) ~[?:1.8.0_181] at info.magnolia.ui.editor.FormPresenter.lambda$null$11(FormPresenter.java:197) ~[magnolia-ui-framework-6.2.8.jar:?] at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:1.8.0_181] at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175) ~[?:1.8.0_181]

When considering this I suggtest raising the priority to Critical (I cannot change it) for obvious reasons that there should never ever be a StackOverflow everywhere.

Comment by Roman Kovařík [ 25/Jun/21 ]

viet.nguyen Can't reproduce by steps provided in the description.

Comment by Viet Nguyen [ 25/Jun/21 ]

Me neither, it does not happen in 6.2.9 anymore, we can consider closing this as fixed.

Comment by Roman Kovařík [ 25/Jun/21 ]

Hi Daniel,

This issue can't be reproduced anymore with the latest https://demo.magnolia-cms.com/.

Could you check again and create a separate ticket for the stack-overflow problem if needed?

Thanks.

Roman

Comment by Roman Kovařík [ 16/Jul/21 ]

For release notes: damLinkField with showOptions=true doesn't produce exception anymore on save of multi locale forms.

Generated at Mon Feb 12 09:39:05 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.