[MGNLUI-672] MagnoliaShell should use CSS for sizing instead of setSizeFull() Created: 18/Feb/13  Updated: 19/Jun/13  Resolved: 19/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Bug Priority: Minor
Reporter: Tobias Mattsson Assignee: Samuli Penttilä
Resolution: Won't Fix Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The call to setSizeFull() is in info.magnolia.ui.vaadin.magnoliashell.MagnoliaShellBase#MagnoliaShellBase



 Comments   
Comment by Aleksandr Pchelintcev [ 19/Jun/13 ]

Actually setting component size through CSS might lead to weird issues. Vaadin's layouting mechanism during a layout phase detects the width/height settings through inline styles and thus might not fire ElementSizeChange events related to a component.

Generated at Mon Feb 12 08:39:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.