[MGNLUI-6797] Server push configuration Created: 21/Jul/21  Updated: 01/Feb/23  Resolved: 16/Nov/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.10
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Richard Gange Assignee: Unassigned
Resolution: Won't Do Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-7749 Reduce grid refresh rate Closed
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Vaadin push issues

 Description   

It would be helpful to have some control over the server push. Some use cases might be:

  • I have an action which changes a lot of values (MGNLWORKFLOW-403)
  • I'm ok with not having changes pushed out as a trade off for performance. I understand how to refresh the UI on demand.
  • Troubleshoot issues.

Notes

Adding a check in JcrDataSourceObservation for the current pushMode would be a good idea, since a developer could disable it. Currently the ui.push() is always executed, nevertheless what the configuration is.

if (ui.getPushConfiguration().getPushMode().isEnabled()) {
  ui.push();
}


 Comments   
Comment by Antonio Tuor [ 16/Nov/21 ]

Hi Guys,

Can you provide a reason, why this will not be added?

Vaadin provides a functionality, but this functionality is ignored by magnolia, so we are not able to get all out of vaadin.
Would be great to get some feedback here, since it's a tiny change, but IMO a huge improvement. Currently a fix for this requires decoration and custom workspace observations, which is a huge effort for such a basic feature.

Thanks and best regards,
Tonio

Comment by Richard Gange [ 16/Nov/21 ]

Hello Tonio-

The main reason I closed it is there is very little chance this would ever be a priority for us. You have no idea how many feature/change requests we get from customers and partners. It's really way more then we could ever hope to fulfil.

I do remember you showing me the custom app you built to do this import. I believe we both agreed on the call that there are other ways of achieving this once a year import rather than having to have the app open. This is the crux of the issue. You could also achieve the same import through a command or a task.

Would be great to get some feedback here, since it's a tiny change, but IMO a huge improvement.

Honestly there are no tiny changes. Every change we make to the software comes with some risk. It also comes with a certain amount of overhead no matter how "tiny" it may seem from the outside.

Currently a fix for this requires decoration and custom workspace observations, which is a huge effort for such a basic feature.

Maybe it does but IIRC you have already done it correct? So for the most part this is in the rear view mirror for you. I don't understand the demand that we must implement this. It would also require that you go and change your own code.

If you want I will reopen the issue but there is such a small chance that anything would ever be done. At some point the reality of the situation sets in and we have to move on. Instead I invite you to present your feature request through our product board https://magnolia.productboard.com. This way it will go through PM and get a proper evaluation. There you can also see the 100s of other requests which have already been submitted.

Kind Regards
Rich

Comment by Antonio Tuor [ 16/Nov/21 ]

Hi Rich,,
Thanks for the extremly fast feedback, I totally understand you with the "tiny" feature, maybe I need to correct my words here.
Magnolia is using Vaadin as a Framework, but in this case here, the framework is not used correctly, e.g. the famework supports disabling the UI.push() but magnolia just ignores this functionality and executes it anyway.
So for me, this is not a feature, it's a bug, since a valid vaadin config is just ignored. Therefore I would think that the task should be moved to a bug, instead of an improvement, and remain opened.
But if you think it also don't get fixed as bug, we can leave it as it is.

Best regards,
Tonio

Generated at Mon Feb 12 09:40:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.