[MGNLUI-7199] Returning to app always select first subapp instead of latest active Created: 03/Jun/22  Updated: 23/Jan/23  Resolved: 23/Jan/23

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.3, 6.2.27
Fix Version/s: 6.3, 6.2.28

Type: Bug Priority: Neutral
Reporter: Roman Kovařík Assignee: Antonín Juran
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLUI-7039 URL after opening app should always c... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-7734 Implementation Sub-task Completed Antonín Juran  
MGNLUI-7735 Code review Sub-task Completed Roman Kovařík  
MGNLUI-7736 Pre-integration QA Sub-task Completed Roman Kovařík  
MGNLUI-7737 Final QA Sub-task Closed Jaromir Sarf  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Maintenance of vaadin8 framework
Sprint: Nucleus 28
Story Points: 2
Team: Nucleus
Work Started:

 Description   
Steps to reproduce:
  1. Open "About Magnolia" app and click to "Libraries license info" tab/subapp there.
  2. Go to app launcher by clicking app launcher icon ("About Magnolia" app is still running).
  3. Go back to "About Magnolia" app
Actual result:

"About Magnolia" tab/subapp is displayed

Expected result:

"Libraries license info" tab/subapp is displayed



 Comments   
Comment by Antonín Juran [ 05/Jan/23 ]

Discovery

LocationController#goToWithoutChecks sets subapp id (the first one from app descriptor) to Location if it doesn't contain any.

Suggested solution

Set the suppapp id to the Location only in case if an app from the Location is not running (AppController#isAppStarted).

Comment by Roman Kovařík [ 05/Jan/23 ]

Sounds fine except the cyclic dependency between LocationController and AppController. We would need to inject the AppController into the LocationController via Provider<>.

Generated at Mon Feb 12 09:44:03 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.