[MGNLUI-7199] Returning to app always select first subapp instead of latest active Created: 03/Jun/22 Updated: 23/Jan/23 Resolved: 23/Jan/23 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 6.3, 6.2.27 |
| Fix Version/s: | 6.3, 6.2.28 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: |
|
|||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | Maintenance of vaadin8 framework | |||||||||||||||||||||||||
| Sprint: | Nucleus 28 | |||||||||||||||||||||||||
| Story Points: | 2 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Description |
| Comments |
| Comment by Antonín Juran [ 05/Jan/23 ] |
DiscoveryLocationController#goToWithoutChecks sets subapp id (the first one from app descriptor) to Location if it doesn't contain any. Suggested solutionSet the suppapp id to the Location only in case if an app from the Location is not running (AppController#isAppStarted). |
| Comment by Roman Kovařík [ 05/Jan/23 ] |
|
Sounds fine except the cyclic dependency between LocationController and AppController. We would need to inject the AppController into the LocationController via Provider<>. |