[MGNLUI-7287] Tabs in content apps are not clickable/visible when showing previous versions Created: 22/Jun/22  Updated: 31/Aug/22  Resolved: 30/Aug/22

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.14
Fix Version/s: 6.3.0, 6.2.23

Type: Bug Priority: Neutral
Reporter: Mercedes Iruela Assignee: Marek Strucka
Resolution: Fixed Votes: 0
Labels: None
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File Screenshot 2022-06-22 at 12.48.45.png    
Issue Links:
Problem/Incident
causality
caused by MGNLUI-5593 Nodes are editable in view and versio... Closed
duplicate
duplicates MGNLUI-7390 When displaying a version's dialog th... Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-7436 Implementation Sub-task Completed Marek Strucka  
MGNLUI-7437 Review Sub-task Completed Adam Siska  
MGNLUI-7438 PiQA Sub-task Completed Jaroslav Simak  
MGNLUI-7439 QA Sub-task Closed Rishab Dhar  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: Maintenance of vaadin8 framework
Sprint: DevX 17
Story Points: 3
Team: DeveloperX

 Description   

This issue is reproducible in the Personas app, that allows versioning and uses tabbedLayout.

Steps to reproduce:

  1. Open the Personas app.
  2. Edit a Persona and publish the change.
  3. Click on 'Show versions' of this Persona and select a previous version.

Expected

All the information from different tabs can be seen.

Actual behaviour

Only content in the first tab can be seen since the rest of tabs are not clickable.

 



 Comments   
Comment by Roman Kovařík [ 22/Jun/22 ]

Discovery:
MGNLUI-5593 disabled whole view for versioned item but could/should disable only tab content so tabs remain clickable. Something like

if (form.asVaadinComponent() instanceof TabSheet) {
     ((TabSheet) form.asVaadinComponent()).forEach(component -> component.setEnabled(false));
} else {
  view.setEnabled(false);
}

 

Generated at Mon Feb 12 09:44:49 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.