[MGNLUI-729] TreeTable bounces on node collapse/expand. Created: 25/Feb/13  Updated: 10/Apr/13  Resolved: 26/Mar/13

Status: Closed
Project: Magnolia UI
Component/s: tree/list
Affects Version/s: None
Fix Version/s: 5.0

Type: Bug Priority: Critical
Reporter: Aleksandr Pchelintcev Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: tech-debt, ui_defect
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: Not Specified Time Spent: Not Specified
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-959 TreeTable rows have different heights Sub-task Closed Mikaël Geljić  
MGNLUI-960 Remove scrolling hack on the client-side Sub-task Closed Mikaël Geljić  
MGNLUI-961 Remove row-based lazy loading for mag... Sub-task Closed Mikaël Geljić  
MGNLUI-962 Remove column widths recalculation Sub-task Closed Mikaël Geljić  
MGNLUI-964 Avoid second UIDL request on location... Sub-task Closed Mikaël Geljić  
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Iteration 2013-12, Iteration 2013-13, Iteration 2013-14

 Description   

For some reason the tree table bounces a bit every time the node is collapsed/expanded. Happens mostly when the tree is scrolled down and has some cached rows in above. UPD: happens even on scroll of tree-table some times.



 Comments   
Comment by Mikaël Geljić [ 25/Mar/13 ]

Bouncing can be caused by several factors that could be identified:
1. Incorrect row heights due to cell content overflowing.
2. There's a scrolling hack on the client-side during update, it seems to be removable.

Besides, when browsing fast with keyboard, selection might turn out of sync with fresh repaints, making it feel as if it were jumping a bit.
The following factors affect responsiveness of the tree:
3. Lazy loading of rows should be dropped / Hierarchical interface guarantees lazy loading per visible nodes
4. Partial updates are currently disabled in Vaadin and should be restored if possible - see http://dev.vaadin.com/ticket/8628
5. Updating location or action bar is done immediately when selection changes, we would need to do this asynchronously
6. Column widths are recalculated when expanding tree further deep, this is a costly client-side operation - esp. without lazy loading

See the following concept page for details: http://wiki.magnolia-cms.com/display/DEV/Concept+-+Blazing+fast+vaadin+trees

I'll create subtasks for tackling these independent issues.

Comment by Mikaël Geljić [ 27/Mar/13 ]

released in magnolia-ui-5.0-alpha4-3 / stable bundle #26

Comment by Mikaël Geljić [ 27/Mar/13 ]

Please also note that there is still room for improvement, among the factors I mentioned in first comment, those were not tackled:
4. partial updates
5. async workbench update

Generated at Mon Feb 12 08:39:41 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.