[MGNLUI-7414] Huge space in dependency tab Created: 04/Aug/22  Updated: 06/Feb/23  Resolved: 27/Dec/22

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 6.2.21
Fix Version/s: 6.3, 6.2.28

Type: Bug Priority: Neutral
Reporter: Yen Lac Tue Assignee: Sang Ngo Huu
Resolution: Fixed Votes: 0
Labels: css
Σ Remaining Estimate: Not Specified Remaining Estimate: Not Specified
Σ Time Spent: 3.25d Time Spent: 0.5d
Σ Original Estimate: Not Specified Original Estimate: Not Specified

Attachments: PNG File dialog_max_size.png     PNG File dialog_small_size.png     PNG File image-2022-12-01-13-32-47-232.png     PNG File image-2022-12-01-13-32-57-460.png     File mtk2_basic.yaml    
Issue Links:
Problem/Incident
Relates
relates to MGNLUI-6444 Chooser dialogs: expand vertically to... Closed
relates to MGNLUI-6555 richtextfield expand button makes it ... Closed
causality
is causing MGNLUI-7816 "Move" dialog in the old framework do... Closed
relation
is related to ADMINCTR-349 Huge space in dependency tab Closed
Sub-Tasks:
Key
Summary
Type
Status
Assignee
MGNLUI-7704 Implementation Sub-task Completed Sang Ngo Huu  
MGNLUI-7705 Review PR Sub-task Completed Quach Hao Thien  
MGNLUI-7706 Pre-int QA Sub-task Completed Quach Hao Thien  
MGNLUI-7707 QA Sub-task Completed Quach Hao Thien  
MGNLUI-7710 Port to 6.3 Sub-task Completed Sang Ngo Huu  
Template:
Acceptance criteria:
Empty
Task DoD:
[X]* Doc/release notes changes? Comment present?
[X]* Downstream builds green?
[X]* Solution information and context easily available?
[X]* Tests
[X]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Epic Link: UI framework: forms, dialogs, content editing
Sprint: Nucleus 26
Story Points: 2
Team: Nucleus
Work Started:

 Description   

Steps to reproduce

  1. Add tabDependencies into https://demoauthor.magnolia-cms.com/.magnolia/admincentral#app:resources:edit;/mtk2/dialogs/pages/basic.yaml:edit (please refer the attached file mtk2_basic.yaml)
  2. Create a page which have referencesTo and referencesFrom
  3. Open page and select "Edit page properties"
  4. Select Dependencies tab
  5. Expand the dialog

Expected results

Content should display as below

Actual results

There is huge space between sections

Workaround

Development notes

https://git.magnolia-cms.com/projects/PLATFORM/repos/ui/browse/magnolia-resurface-theme/src/main/resources/VAADIN/themes/resurface/dialogs.scss#116

 



 Comments   
Comment by Roman Kovařík [ 08/Dec/22 ]
  • Find the reason why we have this kind of calculation

If we check the history we can see this was done so the grid in choosers fits the dialog.

In the dependency tab we have two grids instead of one so the first one takes whole visible space.

Generated at Mon Feb 12 09:45:57 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.