[MGNLUI-7668] Validation message not displayed in horizontal layout Created: 02/Dec/22 Updated: 06/Feb/23 Resolved: 06/Feb/23 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs |
| Affects Version/s: | 6.2.26 |
| Fix Version/s: | 6.3, 6.2.29 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Roberto Gaona | Assignee: | Jaromir Sarf |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | 0.5d | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Issue Links: |
|
|||||||||||||||||||||||||
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Bug DoR: |
[X]*
Steps to reproduce, expected, and actual results filled
[X]*
Affected version filled
|
|||||||||||||||||||||||||
| Date of First Response: | ||||||||||||||||||||||||||
| Epic Link: | FieldsMaintenance | |||||||||||||||||||||||||
| Sprint: | Nucleus 29 | |||||||||||||||||||||||||
| Story Points: | 2 | |||||||||||||||||||||||||
| Team: | ||||||||||||||||||||||||||
| Work Started: | ||||||||||||||||||||||||||
| Description |
| Comments |
| Comment by Jaromir Sarf [ 25/Jan/23 ] |
|
Discovery: HorizontalLayout does not have decorated fields. The fix could be inject and use FieldComponentDecorator in createLayout method. For example something like this: private final FieldComponentDecorator fieldComponentDecorator; @Inject protected HorizontalLayoutProducer(FieldComponentDecorator fieldComponentDecorator) { this.fieldComponentDecorator = fieldComponentDecorator; } @Override public Component createLayout(HorizontalLayoutDefinition definition, Map<EditorPropertyDefinition, Component> mappings) { return new HorizontalLayout(mappings.entrySet().stream() .map(entry -> fieldComponentDecorator.decorateField(entry.getValue(), entry.getKey())) .toArray(Component[]::new)); } In this case is also need to fix exception thrown by info.magnolia.ui.vaadin.extension.FocusFieldCaption. |