[MGNLUI-771] Setting active tab in TabBarWidget should not be done with an event Created: 04/Mar/13 Updated: 19/Jun/13 Resolved: 19/Jun/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.0 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Christopher Zimmermann | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Description |
|
Dialogs are added to the DOM by MagnoliaShellViewImpl.addModal() after they are created. The problem is that when the dialog is created, an ActiveTabChangedEvent is sent from the MagnoliaTabSheetConnector activeTab stateChangeHandler to the TabBarWidget to set the active tab label. But this event is sent before the TabBarWidget is initialised, resulting in no tab label being selected. There must be a better route - ie RPC that would not be dependant on the timing of creation. Concretely - this Timer delay should be removed. |