[MGNLUI-772] Active Tab Label is sometimes not "hilighted" when modal dialog opens Created: 04/Mar/13  Updated: 07/Mar/13  Resolved: 07/Mar/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Bug Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-644 Dialogs can be opened modally, blocki... Closed
relates to MGNLUI-771 Setting active tab in TabBarWidget sh... Closed
duplicate
is duplicated by MGNLUI-792 Default tab not selected, when you op... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Most often seen in GWT DEV Mode.
A timing problem related to the new implementation of modal dialogs. The dialog is created (and it tries to set active tab) before it is added to the DOM by the MagnloiaShellViewImpl.

For now, adding a slight delay to the firing of the event in MagnoliaTabSheetConector stateChangeHandler().



 Comments   
Comment by Jozef Chocholacek [ 07/Mar/13 ]

I don't see any commit assigned to the issue, nor any comment referencing any other solution.

Comment by Christopher Zimmermann [ 07/Mar/13 ]

Shoot - used wrong ticket number in commit. Message is:
MGNLUI-722 Added timer delay to firing the ActiveTabChangedEvent in MagnoliaTabSheetConnector

Change is in addStateChangeHandler - onStateChanged:

Here is the new code:
// TODO: Implement the activation of the tab label in a more robust way that is not subject to timing issues. (see MGNLUI-771)
new Timer() {
@Override
public void run()

{ eventBus.fireEvent(new ActiveTabChangedEvent(tabConnector.getWidget(), false)); }

}.schedule(10);

Comment by Jozef Chocholacek [ 07/Mar/13 ]

OK, now I see & can close

Generated at Mon Feb 12 08:40:08 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.