[MGNLUI-787] Get rid of SASS compilation warnings in the console Created: 04/Mar/13  Updated: 03/Jul/13  Resolved: 02/Jul/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0.1

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Won't Fix Votes: 0
Labels: alpha4, theme
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Currently SASS compilation is processed on-the-fly, and in the current state of the SassCompiler, it does fire some warnings like the following:

WARNING: Base-level rule contains the parent-selector-referencing character '&'; the character will be removed:
.v-sa & .v-button-link:focus {
	outline-offset: -3px;
}

These warnings are due to the fact that Vaadin's base theme is included at top level, not within a theme mixin, i.e. all theme style rules are generated like .v-button {...} instead of .admincentral .v-button {...} which would be costly for browser rendering.

The effective reason why such warnings are fired is related to multiple-theme environments, like in a page that would embed several vaadin portlets with different themes. In our case, it has no use and causes no harm to ignore these warnings. However, we definitely need a way to reduce them to silence.

This is the vaadin issue we need to push a little bit:



 Comments   
Comment by Mikaël Geljić [ 02/Jul/13 ]

These warnings occur at Sass compilation time, which is anyway unlikely to show up for module developers since we have build-time compilation and productionMode ON; they will just use the precompiled CSS from the admincentral jar.

Let's not worry about these warnings.

Generated at Mon Feb 12 08:40:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.