[MGNLUI-7954] Make a Notification provider injectable Created: 21/Mar/23 Updated: 31/Mar/23 Resolved: 28/Mar/23 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 6.3.0, 6.2.31 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Roman Kovařík | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Σ Remaining Estimate: | Not Specified | Remaining Estimate: | Not Specified |
| Σ Time Spent: | Not Specified | Time Spent: | Not Specified |
| Σ Original Estimate: | Not Specified | Original Estimate: | Not Specified |
| Sub-Tasks: |
|
|||||||||||||||||||||||||
| Template: | ||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
|||||||||||||||||||||||||
| Task DoD: |
[X]*
Doc/release notes changes? Comment present?
[X]*
Downstream builds green?
[X]*
Solution information and context easily available?
[X]*
Tests
[X]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
|||||||||||||||||||||||||
| Visible to: |
Thomas Duffey
|
| Description |
Steps to reproduce
Expected resultsTest/build always passes. Actual resultshttps://jenkins.magnolia-cms.com/blue/organizations/jenkins/platform%2Fui/detail/PR-2350/21/pipeline#step-421-log-1152[ERROR] RowDraggerTest.showWarningMessageWhenDropConstraintIsNotAllowedAt:129 » NullPointer Cannot invoke "com.vaadin.server.AbstractClientConnector.addExtension(com.vaadin.server.Extension)" because "target" is null WorkaroundRe-trigger the build until the build is successful. Development notesThe failures are more often after update of a junit runner. There don't seem to be any previous tests which would not clean a resources. It might be connected to reusing threads etc. As the investigation of the cause was not successful we suggest to avoid static Vaadin calls to show notifications which would make testing easier. We replace usages of Notification.show only in classes with no public ctors. The rest can be tackled when the constructors need to be changed. |