[MGNLUI-798] Streamline DefaultLocation & ContentLocation Created: 05/Mar/13  Updated: 28/Jun/13  Resolved: 28/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.0

Type: Improvement Priority: Neutral
Reporter: Daniel Lipp Assignee: Daniel Lipp
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)

 Description   

Current implementation of DefaultLocation & ContentLocation are unnecessarily complicated:
DefaultLocation

  • unused code should go
  • default constructor, DefaultLocation(String), parseLocation(String), setAppParams(String), setAppType(String), setAppId(String), setSubAppId(String)
  • all members except parameter should be final

ContentLocation

  • will crash on parameter being null - should e.g. be considered in ContentLocation.wrap


 Comments   
Comment by Daniel Lipp [ 28/Jun/13 ]

there's no more ContentLocation

Generated at Mon Feb 12 08:40:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.