[MGNLUI-8306] Footer shows the number of results when searching Created: 08/Sep/23 Updated: 12/Feb/24 |
|
| Status: | Open |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Story | Priority: | Neutral |
| Reporter: | Laura Delnevo | Assignee: | Unassigned |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | dx-core-6.3, searchx | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: | |||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Documentation update required: |
Yes
|
||||||||
| Date of First Response: | |||||||||
| Epic Link: | SearchX 1. In-App search & Top Nav | ||||||||
| Team: | |||||||||
| Description |
ACs
Designs |
| Comments |
| Comment by Roman Kovařík [ 12/Feb/24 ] |
|
Hey, Vaadin 8 requires the number of items to render the scrollbar, unlike the newer versions of the framework where you can have only an infinite scrollbar. What I want to say is that this performance problem already exists, and we could cache the number so that the query doesn't run a second time for the footer. |
| Comment by Michael Duerig [ 12/Feb/24 ] |
|
In JCR the number of items returned from the query is potentially available from RowIterator.getSize() and the RowIterator can be obtain from the QueryResult. However, getSize might return -1 in which case the size is not available. My comment from above (https://jira.magnolia-cms.com/browse/MGNLUI-8306?focusedId=395385&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-395385) was in relation to this case where you would need to iterate over all results to count them. |