Keyboard: As a user, I can navigate around the new UI using basic (common) keyboard commands (leftovers from previous sprint) (MGNLUI-1641)

[MGNLUI-847] Can't use keyboard to switch between editing view and preview of a page Created: 06/Mar/13  Updated: 30/Sep/13  Resolved: 12/Sep/13

Status: Closed
Project: Magnolia UI
Component/s: page editor, user interaction
Affects Version/s: None
Fix Version/s: 5.1

Type: Sub-task Priority: Critical
Reporter: Andreas Weder Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: review-ux-201303
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Device: Safari 6.0.2, Mac OS X 10.8.2
Build: magnolia_bundle-stable #18


Issue Links:
Relates
relates to MGNLUI-2113 ESCAPE keyboard handlers dont fire wh... Closed
relates to MGNLUI-2187 Keyboard: ESCAPE press in page editor... Closed
Template:
Date of First Response:
Sprint: 5.1 Beta1- Frontend

 Description   

In 4.5, hitting preview in the page editor takes you from the editing view to the preview and vice versa. This no longer works in 5.0.

Solution in pagesEditorSubApp.onEscape():
add: pageEditorPresenter.onAction(PageEditorListener.ACTION_VIEW_PREVIEW);

PagesEditorSubapp is where the action is normally run.

But now a problem with if escape is hit within the page editor.
See:info.magnolia.ui.vaadin.gwt.client.widget.PageEditorViewImpl#initDomEventListeners



 Comments   
Comment by Christopher Zimmermann [ 12/Sep/13 ]

Tested on firefox.
May be problems on chrome - but they are not related to this commit.

Feature works whether user is focussed in app or in the iframe.

Escape key now also triggers the preview and edit actions.
It determines the current mode by checking the location.

Page preview in an iframe now also bubbles keyboard events up to page editor.

Comment by Espen Jervidalo [ 12/Sep/13 ]

as the info.magnolia.ui.vaadin.gwt.client.widget.PageEditorView#initDomEventListenersOnPreview is actually used for both preview and edit, please rename to something more generic like "initKeyListeners" and move it out of the if(edit) - else as it is used by both

Generated at Mon Feb 12 08:40:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.