Keyboard: As a user, I can navigate around the new UI using basic (common) keyboard commands (leftovers from previous sprint)
(MGNLUI-1641)
|
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | page editor, user interaction |
| Affects Version/s: | None |
| Fix Version/s: | 5.1 |
| Type: | Sub-task | Priority: | Critical |
| Reporter: | Andreas Weder | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | review-ux-201303 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Device: Safari 6.0.2, Mac OS X 10.8.2 |
||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Date of First Response: | |||||||||||||
| Sprint: | 5.1 Beta1- Frontend | ||||||||||||
| Description |
|
In 4.5, hitting preview in the page editor takes you from the editing view to the preview and vice versa. This no longer works in 5.0. Solution in pagesEditorSubApp.onEscape(): PagesEditorSubapp is where the action is normally run. But now a problem with if escape is hit within the page editor. |
| Comments |
| Comment by Christopher Zimmermann [ 12/Sep/13 ] |
|
Tested on firefox. Feature works whether user is focussed in app or in the iframe. Escape key now also triggers the preview and edit actions. Page preview in an iframe now also bubbles keyboard events up to page editor. |
| Comment by Espen Jervidalo [ 12/Sep/13 ] |
|
as the info.magnolia.ui.vaadin.gwt.client.widget.PageEditorView#initDomEventListenersOnPreview is actually used for both preview and edit, please rename to something more generic like "initKeyListeners" and move it out of the if(edit) - else as it is used by both |