[MGNLUI-863] Drop obsolete action definitions in contacts app Created: 11/Mar/13 Updated: 14/Mar/13 Resolved: 14/Mar/13 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.0 |
| Type: | Task | Priority: | Neutral |
| Reporter: | Daniel Lipp | Assignee: | Daniel Lipp |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoR: |
Empty
|
| Date of First Response: |
| Description |
|
With latest refactorings some of the action definitions for contacts app have become empty implementations and are no longer required:
|
| Comments |
| Comment by Federico Grilli [ 13/Mar/13 ] |
|
I just stumbled into this exception http://pastebin.com/a5CFc3XJ when trying to add a new page in the website tree. I think the removed defs are actually needed to resolve the correct actions. In the above case, in info.magnolia.ui.model.builder.MappingFactoryBase.resolveImplementationClass(D) we end up with the following wrong mapping info.magnolia.ui.admincentral.dialog.action.SaveDialogActionDefinition=class info.magnolia.ui.app.contacts.dialog.action.SaveContactDialogAction |
| Comment by Daniel Lipp [ 14/Mar/13 ] |
|
Reverting - those empty types are currently still required. |