[MGNLUI-877] Factories should not copy contents of registries into state of their own Created: 14/Mar/13  Updated: 07/Jun/13  Resolved: 07/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: framework
Affects Version/s: None
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Tobias Mattsson Assignee: Tobias Mattsson
Resolution: Obsolete Votes: 0
Labels: architecture
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-581 Lookup of an action implementation in... Closed
is related to MGNLUI-1175 Convert ui-model into ui-api Closed
supersession
is superseded by MGNLUI-1590 Replace FieldValidatorRegistry with a... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

It should be the registries that own the mappings and the factories should query the registry each time. Otherwise changes in a registry has no effect.

This effects all classes inheriting from MappingFactoryBase.

  • info.magnolia.ui.dialog.action.DialogActionFactoryImpl
  • info.magnolia.ui.form.field.validation.ValidatorFieldFactory
  • info.magnolia.ui.admincentral.mediaeditor.editmode.factory.EditModeProviderFactory
  • info.magnolia.ui.form.field.builder.FieldFactory
  • info.magnolia.ui.form.action.FormActionFactoryImpl

The class MappingFactoryBase should be removed.

The lookup of implementation based on the class of the definition needs to go to the registries. We should introduce a base class for this since the logic will be identical for all of them. See MGNLUI-581 for changes pending for this logic.


Generated at Mon Feb 12 08:41:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.