[MGNLUI-888] conf by code's WorkbenchBuilder is out of sync with definition Created: 15/Mar/13  Updated: 15/Mar/13  Resolved: 15/Mar/13

Status: Closed
Project: Magnolia UI
Component/s: configuration, framework
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: framework
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

WorkbenchBuilder is a few steps behind WorkbenchDefinition. It misses the following api:

  • .name(String)
  • .includeProperties(boolean)
  • .editable(boolean)
  • .dialogWorkbench(boolean)

Additionally, we should:

  • use varargs for nodeType*s*, similar to columns (I originally thought we could define only one nodeType, until looking inside and seeing that addNodeType was used)
  • rename .root(String) to .path(String) to match the definition.

Generated at Mon Feb 12 08:41:17 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.