[MGNLUI-936] SaveImportDialogAction should extend CommandActionBase Created: 21/Mar/13  Updated: 10/Mar/21  Resolved: 10/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: framework
Affects Version/s: 5.0
Fix Version/s: None

Type: Task Priority: Neutral
Reporter: Eric Hechinger Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: actions
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-906 Create Import Export Action Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty

 Description   

Currently SaveImportDialogAction used to import an XML node structure has to implement code already present in CommandActionDefinition.
Reason: Action builder from worbench action and dialog action are not onlined.

Alter Action refactoring, would be great if we could use the already checked in ImportAction in dialog or a DialogAction that have a Command call capability.



 Comments   
Comment by Eric Hechinger [ 04/Jun/13 ]

AbstractCommandAction may define a onPreExecute() like onPostExecute().
This onPreExecute() should populate the related Item based on the JcrNodeadapter before performing the execute.
onPreExecute() should contains this code snipped

final JcrNodeAdapter itemChanged = (JcrNodeAdapter) item;
JcrNodeAdapter importXml = (JcrNodeAdapter) itemChanged.getChild("import");

Generated at Mon Feb 12 08:41:45 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.