[MGNLVA-5] Updating Vaadin to version 8.8.2 causes compilation issues Created: 29/May/19  Updated: 03/Jun/19  Resolved: 03/Jun/19

Status: Closed
Project: Magnolia Vaadin Compatibility Addons
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3

Type: Bug Priority: Neutral
Reporter: Federico Grilli Assignee: Adam Siska
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLUI-5119 Update Vaadin to version 8.8.2 Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Epic Link: 6.1 library update
Sprint: Foundation 12
Story Points: 3

 Description   

While in the scope of MGNLUI-5119 I tried to update Vaadin to 8.8.2 in compatibility addons too. This caused

Compilation failure
[ERROR] /Users/fgrilli/devel/workspace/magnolia/vaadin-compatibility-addons/vaadin-compatibility-context-menu/src/main/java/com/vaadin/contextmenu/client/MyVOverlay.java:[22,24] setApplicationConnection(com.vaadin.client.ApplicationConnection) in com.vaadin.contextmenu.client.MyVOverlay cannot override setApplicationConnection(com.vaadin.client.ApplicationConnection) in com.vaadin.client.ui.VOverlay
[ERROR]   overriding method is static

due to a workaround used by https://github.com/vaadin/context-menu in version 2.0.0 which is no longer compatible with the latest Vaadin.
Trying to update the addon to its latest 3.0.0 version, a complete rewrite (still with an API backward compatibility, so they claim), fails to apply some patch of ours.

It is no so clear, at least to me, how that patch should be changed, nor if it is actually still needed.
Failing to fix this has repercussions on the widgetset compilation which fails with a message similar to the one mentioned above.

Finally, given the update to Vaadin 8.8.2 the addons version will probably need a bump to 1.3


Generated at Mon Feb 12 09:58:22 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.