Workbench for browsing categories and products
(MGNLWCS-6)
|
|
| Status: | Closed |
| Project: | Websphere Commerce Integration |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.0 |
| Type: | Sub-task | Priority: | Neutral |
| Reporter: | Jaroslav Simak | Assignee: | Robert Šiška |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Date of First Response: | |||||||||
| Comments |
| Comment by Robert Šiška [ 02/Sep/14 ] |
|
Commits: https://git.magnolia-cms.com/gitweb/?p=enterprise/websphere-commerce.git;a=commit;h=9ce6e229332b622227ff97bea8d00e0733773ff8 |
| Comment by Jan Haderka [ 05/Sep/14 ] |
(some of those were already fixed by later commits, but since there's no comprehensive overview of code changes, pls double check) In general lot of that code looks very generic and should be extracted to abstract/common parent or back in DAM or in UI in general. While not necessary right now, keep it in mind and preferably contribute it back to DAM or you will have to reimplement it again, once DAM or UI provides similar functionality. |
| Comment by Aleksandr Pchelintcev [ 05/Sep/14 ] |
Otherwise, looks good and seems to go into a correct direction from App Framework point of view. |
| Comment by Robert Šiška [ 08/Sep/14 ] |
|
Most of the issues pointed out by Jan are about code which is based on emerging asset app prototype. When the DAM 2.1 is released, that code will be removed. |