[MGNLWEBDAV-44] Support editing HTML resources through WebDAV Created: 12/Aug/14  Updated: 12/Sep/14  Resolved: 10/Sep/14

Status: Closed
Project: WebDAV (closed)
Component/s: None
Affects Version/s: 2.0.1
Fix Version/s: 2.1.1

Type: New Feature Priority: Neutral
Reporter: Vivian Steller Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: File patch-add-html-resource.diff    
Issue Links:
causality
is causing MGNLWEBDAV-45 MGNLWEBDAV-44 broke binary compatibility Closed
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Date of First Response:

 Description   

We're missing the possibility to edit static HTML files in Magnolia resources module via WebDAV. This functionality is required for kickstart.io

Patch included!
The patch also modifies some code snippets that prevent developers to extend/patch the WebDav module's classes.

Thank you!



 Comments   
Comment by Roman Kovařík [ 03/Sep/14 ]
  1. Parametric constructors should be probably deprecated with comment that N2B is used for configuration.
  2. info.magnolia.module.webdav.mapping.ResourcesMapping.textStringProperty should have a getter/setter.
  3. Please remove @version $Id$ from javadoc, it's remnant from SVN.
  4. DamMapping's javadoc still mentions 'dms'.
  5. You can use info.magnolia.module.resources.ResourceTypes constants where needed.
  6. Correct checkstyle.
  7. ResourcesMapping.set/getTemplateNameToExtension(Map<String, String>): Replacing on every call is really not good solution. Getters/Setters shouldn't change passed values. Create class for mapping, somothing like this http://git.magnolia-cms.com/gitweb/?p=modules/data.git;a=blob;f=src/main/java/info/magnolia/module/data/app/actions/ConfiguredSubAppMapping.java;h=e74195e37647fd15bd4bf9079bc8c4a6d95d214c;hb=7e6b1170f97f246e6f65daa60cac55e2449c95c1
    Otherwise looks OK, good work!
Comment by Roman Kovařík [ 04/Sep/14 ]
  1. ResourcesMappingTest: contansts exist in ResourceTypes.
  2. For regular use, instantiate this class from its repository configuration using node2bean. -> This class should be instantiated by Node2Bean
  3. ResourcesMapping
  • You can assign a default value to prevent failure on missing textStringProperty configuration private String textStringProperty = "text";
  • Please remove the commented code // private Map<String, String> templateNameToExtension = new HashMap<String, String>();
Comment by Roman Kovařík [ 09/Sep/14 ]

QA: configuration properties for resources template/extension are swapped. Please also check if all workspaces are working (e.g. dam).

Comment by Roman Kovařík [ 10/Sep/14 ]

QA: changes in WebDav configuration break connection.
Try to:

  1. Define WebDAVMappingProvider as singleton component in module descriptor definition.
  2. info.magnolia.module.webdav.WebDAVMappingProvider.mappingFor(String): call CacheModule.getMappings()
  3. info.magnolia.module.webdav.servlet.MgnlWebdavServlet inject this provider or get in from Components if it won't be possible to inject it.
  4. info.magnolia.module.webdav.WebDAVMappingProvider.WebDAVMappingProvider(): WebDavModule should be injected.
  5. info.magnolia.module.webdav.WebDAVModule: inject provider

Please add also configuration for processed html.

Generated at Mon Feb 12 11:11:13 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.