[MGNLWLS-11] Migrate to Magnolia 4.5 Created: 05/Jun/12 Updated: 23/Jul/12 Resolved: 23/Jul/12 |
|
| Status: | Closed |
| Project: | Oracle WebLogic Compatibility |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 1.3 |
| Type: | Task | Priority: | Major |
| Reporter: | Milan Divilek | Assignee: | Milan Divilek |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoR: |
Empty
|
||||||||
| Date of First Response: | |||||||||
| Comments |
| Comment by Jan Haderka [ 25/Jun/12 ] |
+ protected List<Task> getBasicInstallTasks(InstallContext installContext) {
+ final List<Task> installTasks = new ArrayList<Task>();
+ installTasks.addAll(super.getExtraInstallTasks(installContext));
Why do you need to add extra install tasks into basic tasks? If those extra tasks need to be executed BEFORE basic tasks, then just add tasks directly, but don't leave them in the other method or they will be executed twice! |
| Comment by Jan Haderka [ 02/Jul/12 ] |
|
And what happened to the basic install tasks that WLS should inherit from DefaultModuleVersionHandler? Do you think they are defined there just for fun of it? |
| Comment by Jan Haderka [ 02/Jul/12 ] |
|
Unless there is a dare need to reorder basic installation tasks, you should add custom tasks after the default ones. If there is a need to reorder tasks then it should be documented in the comment in the code. |
| Comment by Jan Haderka [ 19/Jul/12 ] |
|
Shoudn't you also add all the extra install tasks from the super class? Granted that list is empty now, but if we decide to add some extra install tasks to the DefaultModuleVersionHandler it would produce a bug here. |