[MGNLWLS-11] Migrate to Magnolia 4.5 Created: 05/Jun/12  Updated: 23/Jul/12  Resolved: 23/Jul/12

Status: Closed
Project: Oracle WebLogic Compatibility
Component/s: None
Affects Version/s: None
Fix Version/s: 1.3

Type: Task Priority: Major
Reporter: Milan Divilek Assignee: Milan Divilek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLEE-235 Remove weblogic 9 support due to jdk ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Comments   
Comment by Jan Haderka [ 25/Jun/12 ]
+    protected List<Task> getBasicInstallTasks(InstallContext installContext) {
+        final List<Task> installTasks = new ArrayList<Task>();
+        installTasks.addAll(super.getExtraInstallTasks(installContext));

Why do you need to add extra install tasks into basic tasks? If those extra tasks need to be executed BEFORE basic tasks, then just add tasks directly, but don't leave them in the other method or they will be executed twice!

Comment by Jan Haderka [ 02/Jul/12 ]

And what happened to the basic install tasks that WLS should inherit from DefaultModuleVersionHandler? Do you think they are defined there just for fun of it?

Comment by Jan Haderka [ 02/Jul/12 ]

Unless there is a dare need to reorder basic installation tasks, you should add custom tasks after the default ones. If there is a need to reorder tasks then it should be documented in the comment in the code.
BTW just looking at that task, is there any reason why it has to be in basic tasks instead of in extra tasks?
(And yes, I know it was me who forced reordering initially and who put that task in the basic rather then extra tasks. Sorry.)

Comment by Jan Haderka [ 19/Jul/12 ]

Shoudn't you also add all the extra install tasks from the super class? Granted that list is empty now, but if we decide to add some extra install tasks to the DefaultModuleVersionHandler it would produce a bug here.

Generated at Mon Feb 12 10:24:40 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.