[MGNLWORKFLOW-109] WorkflowManager: expose generic interface of WorkItem instead of ProcessInstance Created: 09/Aug/13  Updated: 15/Aug/13  Resolved: 12/Aug/13

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLWORKFLOW-104 Allow commenting when rejecting an ac... Closed
is depended upon by MGNLWORKFLOW-58 As a reviewer I can see which page wi... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Comments   
Comment by Tobias Mattsson [ 12/Aug/13 ]

Okay, so if i understand this correctly, we're dropping the WorkflowInstance abstraction and introducing an abstraction around work items. The latter is not a replacement for the former.

  • WorkflowManager.launch no longer returns WorkflowInstance. Makes sense if we're removing WorkflowInstance, but the javadoc is incorrect. It says that it returns WorkItem, which it doesn't and couldn't since the flow is not guaranteed to be in a work item when the launch method returns.
  • These constants should be aligned to use the same value CompleteTaskCommand#TASK_ID, WorkflowConstants#MESSAGE_WORK_ITEM_ID
Comment by Espen Jervidalo [ 12/Aug/13 ]

I'm pretty sure this is dead code:
info.magnolia.module.workflow.commands.CompleteTaskCommand

The ui-centric implementation is in:
info.magnolia.module.workflow.action.CompleteTaskAction

Should we provide a Command for it? can't be rolled back. on the other hand it might be useful to launch it from a webservice..

Generated at Mon Feb 12 10:06:51 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.