[MGNLWORKFLOW-175] i18n: use new i18n for WorkItemHandlers Created: 02/Dec/13  Updated: 18/Feb/14  Resolved: 21/Jan/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.2
Fix Version/s: 5.3

Type: Improvement Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Comments   
Comment by Daniel Lipp [ 14/Jan/14 ]

Only realized in QA phase that there's > 5 places where @Deprecated's without "since <version> + what to use instead" have been introduced.

Comment by Espen Jervidalo [ 21/Jan/14 ]

resolved on branch

Comment by Roman Kovařík [ 24/Jan/14 ]

I'm little lost:

WorkflowBaseModuleVersionHandler:
register(DeltaBuilder.update("5.2.1", "")

WorkflowBaseModuleVersionHandlerTest.testUpdateTo53ChangesActivationSubjects():
@Test
+    public void testUpdateTo53ChangesActivationSubjects() throws RepositoryException, ModuleManagementException {
+        // GIVEN
+        setup52();
+
+        // WHEN
+        executeUpdatesAsIfTheCurrentlyInstalledVersionWas(Version.parseVersion("5.1"));
  • test name says UpdateTo53
  • added delta version to version hander is 5.2.1
  • shouldn't be the delta version also 5.3 (delta 5.2.1 is not on magnolia-workflow-5.2.x branch so it won't be executed on update from 5.2.2)?
Comment by Espen Jervidalo [ 29/Jan/14 ]

yes, you are right, it was fixed in 99aaa6c061c0c28e26aa88cb2790fc5a51a55c90

Generated at Mon Feb 12 10:07:30 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.