Timed activation (MGNLWORKFLOW-126)

[MGNLWORKFLOW-182] Persist session Created: 12/Dec/13  Updated: 22/Jan/14  Resolved: 21/Jan/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: Base
Affects Version/s: 5.2.1
Fix Version/s: 5.3

Type: Sub-task Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Outdated Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Date of First Response:

 Comments   
Comment by Espen Jervidalo [ 10/Jan/14 ]

All commits are on parent ticket.

Comment by Daniel Lipp [ 10/Jan/14 ]

Various issues:

  • WorkflowNodeTypes
  • javadoc for #KSession is wrong
  • JcrSessionFactory
  • loadKieSession()
  • never closes the InputStream!
  • ignores potential RepositoryExceptions

in general:

  • we need unit-tests
  • naming
  • "kSession" is not a good name for the new nodeType, as this already JBPM specific (e.g. we have workflowInstance although the impl in JBPM is called processInstance)
  • don't use prefix "Mgnl" but rather something that describes what's special about the type: e.g. MgnlRuntimeEnvironment -> JcrRuntimeEnvironment
  • javadoc of most new types is invalid
Comment by Espen Jervidalo [ 21/Jan/14 ]

just for the record. Most of the issues were already resolved in other commits.

kSession and workflowInstance will be changed, see linked ticket.
Mgnl is legit imo for MgnlRuntime* classes. They are not bound to JCR, they really are Magnolias extension to to super classes, putting everything in place as wee need them. I removed the prefix in all other cases.

resolving this ticket, as it was mostly overhauled by MGNLWORKFLOW-189

Generated at Mon Feb 12 10:07:34 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.