[MGNLWORKFLOW-195] Exception handling in JbpmWorkflowManager swallowing errors Created: 22/Jan/14 Updated: 25/Mar/14 Resolved: 25/Mar/14 |
|
| Status: | Closed |
| Project: | Magnolia Workflow Module |
| Component/s: | None |
| Affects Version/s: | 5.2.1 |
| Fix Version/s: | 5.3 |
| Type: | Improvement | Priority: | Major |
| Reporter: | Dean Pullen | Assignee: | Federico Grilli |
| Resolution: | Done | Votes: | 0 |
| Labels: | jbpm, logging, support, workflow | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||
| Template: |
|
||||
| Acceptance criteria: |
Empty
|
||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||
| Date of First Response: | |||||
| Description |
|
The JbpmWorkflowManager is currently performing a catch-all via java.lang.Exception in the majority of methods, e.g. launch, completeWorkItem, initKnowledgeService which is generally considered slightly iffy practice. More importantly, any exception is being caught and subsequently swallowing any useful exceptions (and thus logging) by only throwing a RuntimeException without any logging. Synopsis: Jbpm workflow errors are being swallowed and not output to any log. |
| Comments |
| Comment by Espen Jervidalo [ 22/Jan/14 ] |
|
Could you elaborate what kind of Exceptions you get? The thing with Exceptions handling in JBPM is a bit special, in general you're not supposed to catch any Exception, but rather handle them inside your process. Cheers |
| Comment by Espen Jervidalo [ 27/Feb/14 ] |
|
When disabling the jbpm engine, you get a debug message when starting the module. It does not fall back to the DefaultManager, so the module stays in an unusable state and throws exceptions like crazy. This should be fixed as part of this ticket. |
| Comment by Federico Grilli [ 25/Mar/14 ] |
|
Done as part of QA see https://git.magnolia-cms.com/gitweb/?p=enterprise/workflow.git;a=commit;h=a129dda2e86850be51c111968ab319d438bea24f |