[MGNLWORKFLOW-212] Workflow CommandWorkItemHandler ignores failed command Created: 19/Feb/14  Updated: 29/Apr/14  Resolved: 29/Apr/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.2.2
Fix Version/s: 5.4

Type: Improvement Priority: Neutral
Reporter: Dean Pullen Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Line 61-65:

 try {
            commandsManager.executeCommand(commandName, parameters);
        } catch (Exception e) {
            parameters.put(Context.ATTRIBUTE_EXCEPTION, e);
        }

commandsManager.executeCommand returns a boolean representing a successful execution of the command. This is ignored by the CommandWorkItemHandler and failed commands that do not explicitly throw an Exception are treated as successful.

Additionally, the throwing of java.lang.Exception in the CommandsManager should possibly be investigated regarding it's necessity.



 Comments   
Comment by Daniel Lipp [ 21/Feb/14 ]

Hi Dean,

As you might have realized I moved the ticket to MGNLWORKFLOW.

Thx for reporting
Daniel

Generated at Mon Feb 12 10:07:52 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.