[MGNLWORKFLOW-219] Disabling the workflow causes error Created: 18/Mar/14 Updated: 25/Mar/14 Resolved: 19/Mar/14 |
|
| Status: | Closed |
| Project: | Magnolia Workflow Module |
| Component/s: | Base |
| Affects Version/s: | 5.2.2 |
| Fix Version/s: | 5.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Release notes required: |
Yes
|
| Description |
|
For instance ERROR lia.module.workflow.commands.LaunchWorkflowCommand: Error launching workflow [activate]. […] Caused by: java.lang.NullPointerException at info.magnolia.module.workflow.jbpm.JbpmWorkflowManager.launch(JbpmWorkflowManager.java:68) Thing is, being disabled, the engine is (rightly) not started in info.magnolia.module.workflow.jbpm.JbpmWorkflowModule.start(..). However, instead of such a bad failure, we should simply warn the user that workflow is disabled. Ideally the workflow actions themselves could be disabled. |
| Comments |
| Comment by Federico Grilli [ 19/Mar/14 ] |
|
Some API breaking changes and binary compatibility breakage due to replacement of occurrences in methods' signature of Provider<WorkflowManager> and WorkflowManager with WorkflowManagerProvider. Renaming of DefaultWorkflowManager to NullWorkflowManager. |