[MGNLWORKFLOW-245] Cleanup WorkflowManager Created: 27/May/14  Updated: 06/Jun/14  Resolved: 05/Jun/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.3
Fix Version/s: 5.4

Type: Improvement Priority: Neutral
Reporter: Espen Jervidalo Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
dependency
is depended upon by MGNLWORKFLOW-250 Allow configuring the name of the map... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Release notes required:
Yes

 Description   

Looking through JbpmWorkflowManager shows some deprecated concepts. We need to re-iterate over:
info.magnolia.module.workflow.jbpm.JbpmWorkflowManager#completeWorkItem

  • checking for present parameters is obsolete and refers to publication related work items. The method is further more not used for actually completing a work item in the human task context. Still it is valid in the context of completing service tasks of an kind
  • info.magnolia.module.workflow.jbpm.JbpmWorkflowManager#getWorkItem
    This one should not be used anymore. it was used to finish a work item for human tasks. Further more the wrapper we initialize only hold the mgnlData map.
  • the hardcoded mgnlData parameter should at least be configurable. Further more it might be of value to not put a map inside a map.

Generated at Mon Feb 12 10:08:11 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.