[MGNLWORKFLOW-258] User shouldn't be notified when publication is finished Created: 18/Jun/14  Updated: 19/Jun/14  Resolved: 18/Jun/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.4
Fix Version/s: 5.4

Type: Bug Priority: Neutral
Reporter: Jaroslav Simak Assignee: Jaroslav Simak
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

5.4-rc1


Attachments: PNG File Screen Shot 2014-06-18 at 09.05.46.png     PNG File Screen Shot 2014-06-18 at 09.18.37.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Steps to reproduce:

  • go to pages
  • publish demo-features inc. subnodes
  • you should see info message at the bottom of the screen (see screenshot)
    Expected:
  • no message should be displayed

I also attached screenshot with configuration which solves the problem.



 Comments   
Comment by Andreas Weder [ 18/Jun/14 ]

Jaroslav: this is for an instance with activated workflow, right?

If it is, let me make sure I understand this: you've reported this because we get the INFO message, although the only thing that has been done at that time is that we've started the workflow. Right?

Is this just a bug, really, that can be easily fixed, or a bigger, more conceptual problem?

Comment by Andreas Weder [ 18/Jun/14 ]

Or is the bug actually that, although "notifyUser" is set to "false", we still send the message?

Comment by Jaroslav Simak [ 18/Jun/14 ]

@Andreas
absolutely correct.

This "bug" can be easily fixed by adding property notifyUser=false to the publication action (see second attached screenshot).

Comment by Andreas Weder [ 18/Jun/14 ]

This should definitely make it into final, as you'll immediately run into this the first time you'll publish nodes that trigger the publication to be run asynchronously. That will confuse users a lot and cause reports.

The property "notifyUser" already exists and its value was in fact set to "false" for async actions configured to run in a work flow, but is seems that that setting was lost. Jaroslav suggests we change the "workflow" module again to set "notifyUser" to "false" for all affected actions both during initial bootstrap and in update tasks. I agree with him.

Comment by Jaroslav Simak [ 18/Jun/14 ]

commit:
https://git.magnolia-cms.com/gitweb/?p=enterprise/workflow.git;a=commitdiff;h=e45c66a3a1797be3a1e64d6b28c3614308c310df;hp=fc3b34a31c50df47851c5f55bdfc7d846c76f5e7

Generated at Mon Feb 12 10:08:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.