[MGNLWORKFLOW-265] Fix delta between fresh install and instance migrated from 4.5 Created: 25/Jul/14  Updated: 29/Oct/15  Resolved: 04/Aug/14

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: 5.4
Fix Version/s: 5.3.4, 5.4.1

Type: Task Priority: Neutral
Reporter: Daniel Lipp Assignee: Espen Jervidalo
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLWORKFLOW-249 demo project users eric and peter are... Closed
relates to MGNLWORKFLOW-255 Add delta task for changes done by MG... Closed
relates to MGNLUI-3084 Messages are not sent to transitive g... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:
Epic Link: Migration (4.5 to 5.2.x)

 Description   

See http://jenkins.magnolia-cms.com/job/int_migration-tests_4.5-to-5.2.x-branch/Diff_Reports/usergroups.html for details.

It turned out that the diff is at least partly related to: magnolia-module-workflow/src/test/resources/users.admin.eric.xml (this file contains the node with uuid 5e6895a6-aca3-4fed-9d38-216e3b889f2a)

-------------
http://jenkins.magnolia-cms.com/job/int_migration-tests_4.5-to-5.2.x-branch/Diff_Reports/users.html

Here it looks like it's peter's bootstrap file:
magnolia-module-workflow/src/test/resources/users.admin.peter.xml (contains uuid 71b77013-e7ac-4fbf-86d5-4aa8ba5d836d)
-------
http://jenkins.magnolia-cms.com/job/int_migration-tests_4.5-to-5.2.x-branch/Diff_Reports/userroles.html



 Comments   
Comment by Espen Jervidalo [ 28/Jul/14 ]

cherry picked commits from related tickets:
076577177fd1d9933158fa041de2fd90cc881ded
aae8666a940c3394cc10c9e8fe1228943f86c0f1

Comment by Espen Jervidalo [ 28/Jul/14 ]

publishers acl_usergroups node was removed from the bootstrap in MGNLWORKFLOW-128.

Comment by Espen Jervidalo [ 29/Jul/14 ]

demo-project bootstraps relation group relation between demo-project-publisher and publisher from 4.5. publisher group is created by workflow module.
-> removing the relation from bootstrap file.

Comment by Espen Jervidalo [ 30/Jul/14 ]

commits on branches:
workflow: MGNLWORKFLOW-265 MGNLWORKFLOW-265-5.3
stk: MGNLWORKFLOW-265 MGNLWORKFLOW-265-2.7
migration-tests: master

Comment by Espen Jervidalo [ 31/Jul/14 ]

added missing update tasks to branches:
stk: MGNLWORKFLOW-265-2.7 and MGNLWORKFLOW-265

Comment by Milan Divilek [ 01/Aug/14 ]

Reopen:
info.magnolia.module.demoproject.setup.RemoveLegacyGroupReferenceTask line 79 - there should be groupManager.getGroup("publishers") instead of groupManager.getGroup("demo-project-publishers") or it will remove new publisher group from demo-project-publishers group. Also GroupManager.getGroup returns null when requested group doesn't exist and then you will get NPE on line 90

info.magnolia.module.demoproject.setup.RemoveLegacyGroupReferenceTask#doExecute
Line 79 Group group = groupManager.getGroup("demo-project-publishers");
Line 90 if (PUBLISHER_UUIDs.contains(uuid) && !uuid.equals(group.getId())) {
Generated at Mon Feb 12 10:08:23 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.