As a user, I can launch the activation workflow so that I can do the review process (MGNLWORKFLOW-43)

[MGNLWORKFLOW-31] Implement JbpmWorkflowManager.notify(...) method Created: 21/Feb/13  Updated: 26/Apr/13  Resolved: 23/Apr/13

Status: Closed
Project: Magnolia Workflow Module
Component/s: jBPM
Affects Version/s: None
Fix Version/s: 5.0

Type: Sub-task Priority: Neutral
Reporter: Jozef Chocholacek Assignee: Jozef Chocholacek
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLUI-1066 MessagesManager: Add a possibility to... Closed
relation
is related to MGNLWORKFLOW-37 As a developer I can test that the jB... Closed
Template:
Date of First Response:
Sprint: Alpha 3, Iteration 2013-12, Iteration 2013-13, Iteration 2013-14, Iteration 2013-15, Iteration 2013-16

 Comments   
Comment by Jozef Chocholacek [ 23/Apr/13 ]

Method has been finished and modified in other MGNLWORKFLOW tickets.

Comment by Espen Jervidalo [ 23/Apr/13 ]

review remarks:
lots of inline comments like // bla but almost no javadoc

info.magnolia.module.workflow.jbpm.JbpmWorkflowManager#notify(String user, String group, Map<String, Object> parameters)
here user actually is the username or the node identifier. it tries to get it by name first, and if it fails it goes for the identifier. What is it supposed to be? if both cases can occur there should be a method for each case.
exceptions are used for control flow, they shouldn't

Generated at Mon Feb 12 10:06:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.