[MGNLWORKFLOW-315] WorkflowPublicationActionDefinition is not replaceable Created: 17/Nov/15 Updated: 19/May/22 Resolved: 19/May/22 |
|
| Status: | Closed |
| Project: | Magnolia Workflow Module |
| Component/s: | None |
| Affects Version/s: | 5.3, 5.4 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Cedric Reichenbach | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
The usage of WorkflowPublicationActionDefinition is hardcoded in WorkflowFormDialogPresenter (line 93): WorkflowPublicationActionDefinition commit = new WorkflowPublicationActionDefinition(); As a consequence, there is no clean way for developers to replace this implementation, e.g. for custom functionality. It's especially confusing since the dialog seems to be partially defined by config:/modules/workflow/dialogs/publish, but action definitions put in there have no effect. For better modularity, that class should probably be referred to through an interface and an implementation provided either through the dialog definition (in JCR) or a module's configuration file. |
| Comments |
| Comment by Roman Kovařík [ 19/May/22 ] |
|
Hello, This ticket is now marked as closed due to one of the following reasons:
If you are still facing a problem or consider this issue still relevant, please feel free to re-open the ticket and we will reach out to you. Thank you, |