[MGNLWORKFLOW-324] Preview page should show the version to be published not the current one Created: 26/Feb/16  Updated: 15/Apr/16  Resolved: 11/Mar/16

Status: Closed
Project: Magnolia Workflow Module
Component/s: None
Affects Version/s: None
Fix Version/s: 5.5.2

Type: Bug Priority: Major
Reporter: Florian Fuchs Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 1
Labels: quickwin, support, usability, ux
Remaining Estimate: 0d
Time Spent: 0.25d
Original Estimate: Not Specified

Attachments: PNG File 1 Page to be published.png     PNG File 2 Edit after publishing.png     PNG File 3 Publication request.png     PNG File 4 Page shown is current not published.png     PNG File View version 1_2.png    
Issue Links:
dependency
duplicate
is duplicated by MGNLWORKFLOW-291 Preview action is showing wrong versi... Closed
relation
is related to MGNLPN-381 Preview / show page actions fail on p... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Release notes required:
Yes
Date of First Response:
Sprint: Basel 34
Story Points: 3

 Description   

In the detail view of a page publication task, there is a action "preview page". This action, however shows the current version of the page, not the version that is going to be published. You really expect to see the version of the page to be published.

Steps to reproduce

  1. Edit a page (see attachment 1).
  2. Publish the changed page.
  3. Edit the same page again, but don't publish it (see attachment 2).
  4. In the publication request sent through Pulse, click on "preview page" (see attachment 3).

-> You'll get to see the page as edited in step 3, not the changes published in step 1 (see attachment 4).

Solution

PreviewPageAction does what it suppose to do, however, task object does not have a attribute called version in this context. I suggest to add the version attribute in PublicationTaskParameterResolver#setTaskContent, therefore PreviewPageAction can display the correct version of a given page.



 Comments   
Comment by Andreas Weder [ 07/Mar/16 ]

Checked with ejervidalo: we're actually creating a new version of a page once you trigger a publication request. So what's really missing here is that we pass a long that version in the URL. The UI will actually do everything else automatically already:

  • it opens the correct page version for the preview.
  • it disables all actions (edit page, publish, unpublish) except the "preview as visitor" action (see here).

I'm thus marking this as "quickwin" and raise its priority as it's both easy to fix but a usability issue at the same time.

Generated at Mon Feb 12 10:08:58 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.